Review Request 121278: Make changing the volume on notifications optional and disabled by default

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121278/#review71273
-----------------------------------------------------------


Thanks Albert for looking at the issue.

We could even avoid the string change, if we wanted to :)

Who else could approve this patch? I added Harald from Phonon project.

- Christoph Feck


On Dec. 2, 2014, 9:15 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121278/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 9:15 p.m.)
> 
> 
> Review request for Gardening Team, Christoph Feck, Martin Klapetek, and Harald Sitter.
> 
> 
> Bugs: 324975
>     http://bugs.kde.org/show_bug.cgi?id=324975
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> I don't see why we should change the volume at all, let the user decide their volume, but since we have the feature i didn't want to remove it completely and instead left if disabled by default.
> 
> 
> Diffs
> -----
> 
>   knotify/notifybysound.cpp 0f5cc50 
>   kcontrol/knotify/knotify.cpp 0c1b34e 
>   kcontrol/knotify/playersettings.ui 54bb627 
> 
> Diff: https://git.reviewboard.kde.org/r/121278/diff/
> 
> 
> Testing
> -------
> 
> Tested it, does change and not change the volume according to the setting in system settings.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-gardening/attachments/20141202/b84b9602/attachment.html>