D27716: Fix accidental revealing of items when the game is restarted after lost from a middle click.

Yuri Chornoivan noreply at phabricator.kde.org
Fri Feb 28 14:50:12 GMT 2020


yurchor accepted this revision.
yurchor added a comment.
This revision is now accepted and ready to land.


  Works for me as expected.

INLINE COMMENTS

> minefielditem.cpp:442
>                      item->release(true);
> -                    if(item->isRevealed())
> -                        onItemRevealed(item);
> +                    // If revealing the item ends the game, stop the loop.
> +                    // since everything that needs to be done for the current game are finished.

Typo: .->,

> minefielditem.cpp:443
> +                    // If revealing the item ends the game, stop the loop.
> +                    // since everything that needs to be done for the current game are finished.
> +                    // Otherwise, if the user has restarted the game, we'll be revealing

Typo: are finished -> is finished

REVISION DETAIL
  https://phabricator.kde.org/D27716

To: yuyichao, mlaurent, yurchor, #kde_games
Cc: kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20200228/1be35187/attachment.html>


More information about the kde-games-devel mailing list