D27330: Fix DESTDIR usage
Antonio Rojas
noreply at phabricator.kde.org
Tue Feb 11 18:46:32 GMT 2020
arojas created this revision.
arojas added reviewers: KDE Games, asturmlechner, lbeltrame, fvogt.
Herald added a subscriber: kde-games-devel.
arojas requested review of this revision.
REVISION SUMMARY
kajongg's build system uses DESTDIR during cmake to construct the command that creates the kajongg and kajonggserver symlinks in bindir. This is a problem for distributions, which usually have separated ckame/make/make install stages with DESTDIR only available in the later one. So distros are currently working around this in different ways, either creating the symlinks manually after make install (Gentoo, Fedora) or defining DESTDIR before running cmake (Arch, Opensuse).
This patch changes the symlink installation process to only make the DESTDIR substitution during make install.
TEST PLAN
cmake && make && make DESTDIR=foo install, symlinks are correctly created inside foo.
REPOSITORY
R387 Kajongg
REVISION DETAIL
https://phabricator.kde.org/D27330
AFFECTED FILES
cmake-modules/KDEPython.cmake
To: arojas, #kde_games, asturmlechner, lbeltrame, fvogt
Cc: kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20200211/cc41351a/attachment.html>
More information about the kde-games-devel
mailing list