D21477: Use the theme file defined sounds if they are declared.
Albert Astals Cid
noreply at phabricator.kde.org
Sat Jun 8 22:58:20 BST 2019
aacid added a comment.
You have a memory leak and some other things like the warnings, but i'll fix them myself and commit.
Thanks for the contribution :)
INLINE COMMENTS
> KBlocksSound.cpp:68
> +
> + qCWarning(KBSound) << "Fall sound : " << m_themeFallSound << endl;
> + qCWarning(KBSound) << "Move sound : " << m_themeMoveSound << endl;
This is by far *not* a warning
REPOSITORY
R391 KBlocks
REVISION DETAIL
https://phabricator.kde.org/D21477
To: jjorge, #kde_games, aacid
Cc: aspotashev, aacid, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20190608/9e2bf78d/attachment-0001.html>
More information about the kde-games-devel
mailing list