D17560: fully port away from kdelibs4support

Albert Astals Cid noreply at phabricator.kde.org
Tue Feb 19 19:16:39 GMT 2019


aacid added inline comments.

INLINE COMMENTS

> toplevel.cpp:236
> +  if (soundEnabled && language.isEmpty())
>    {
> +    const QStringList &systemLanguages = KLocalizedString::languages();

this is wrong, you moved the language.isEmpty up and now the else triggers in cases it should not trigger.

REPOSITORY
  R418 KTuberling

REVISION DETAIL
  https://phabricator.kde.org/D17560

To: sitter, aacid, #kde_games
Cc: kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20190219/68d7a538/attachment.html>


More information about the kde-games-devel mailing list