D23268: add code documentation and minimal code smells improvement

Albert Astals Cid noreply at phabricator.kde.org
Mon Aug 19 20:51:06 BST 2019


aacid added a comment.


  this is unreviawable, please split it in different parts

INLINE COMMENTS

> board.cpp:47
>      : QGraphicsObject()
> -    , m_renderer( renderer )
> +    , m_renderer(renderer) // Set initial renderer value
>  {

this comment is useless

> board.h:218
>  
> -        QList<KBounceBall*> m_balls;
> -        QList<KBounceWall*> m_walls;
> +        QList<KBounceBall*> m_list_balls;
> +        QList<KBounceWall*> m_list_walls;

this rename is useless

REPOSITORY
  R392 KBounce

REVISION DETAIL
  https://phabricator.kde.org/D23268

To: pedrohenriques, #kde_games
Cc: aacid, schwarzer, yurchor, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20190819/d5f662aa/attachment.html>


More information about the kde-games-devel mailing list