D23219: Fix jenkins build of kajongg

Karthik Periagaram noreply at phabricator.kde.org
Sun Aug 18 20:25:35 BST 2019


karthikp added a comment.


  It might be a good idea to harden this fix further:
  
  1. The file name could potentially have spaces in it. So, a simple (`string(REPLACE ...)`) for spaces with underscores should fix that (see D23233 <https://phabricator.kde.org/D23233>).
  2. Instead of using the full path, we could use the path relative to the current source directory (`file(RELATIVE_PATH ...)`)  to get a unique target name. Another option would be to check (`if(TARGET ...)`) and add a numeric suffix as needed. Both would handle the case where the project has the same filename in two different paths. This will still fix bug 376303 by creating shorter target names.

REPOSITORY
  R387 Kajongg

REVISION DETAIL
  https://phabricator.kde.org/D23219

To: jjazeix, #kde_games
Cc: karthikp, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20190818/c6e22bf0/attachment.html>


More information about the kde-games-devel mailing list