D20892: Eliminate some GCC warnings during compilation.

Laurent Montel noreply at phabricator.kde.org
Mon Apr 29 12:07:56 BST 2019


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> abstract_fc_solve_solver.h:28
>      virtual ~FcSolveSolver();
> -    virtual int get_possible_moves(int *a, int *numout) = 0;
> -    virtual bool isWon();
> -    virtual void make_move(MOVE *m);
> -    virtual void undo_move(MOVE *m);
> -    virtual int getOuts();
> -    virtual unsigned int getClusterNumber();
> -    virtual void translate_layout() = 0;
> -    virtual void unpack_cluster( unsigned int k );
> -    virtual MoveHint translateMove(const MOVE &m) = 0;
> -    virtual SolverInterface::ExitStatus patsolve( int _max_positions = -1);
> +    virtual int get_possible_moves(int *a, int *numout) Q_DECL_OVERRIDE = 0;
> +    virtual bool isWon() Q_DECL_OVERRIDE;

remove virtual keyword.
Q_DECL_OVERRIDE is enough. And I think that we can use override directly.

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D20892

To: shlomif, #kde_games, mlaurent
Cc: mlaurent, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20190429/2c8ee20b/attachment.html>


More information about the kde-games-devel mailing list