D20802: Add a layer for showing the removed tiles of the game.

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> gameremovedtiles.cpp:139
> +    // Exit if no tileset has been set to this object.
> +    if (nullptr == m_tiles || m_itemFaces->size() <= 0) {
> +        return;

m_itemFaces->size() <= 0 => isEmpty()

> gameview.cpp:636
> +{
> +    m_showRemovedTiles = show;
> +    m_gameRemovedTiles->setVisible(show);

compare old version and new version to avoid to updateItemsPosition() all the time.

> gameview.h:83
> +     */
> +    void showRemovedTiles(const bool & show);
>  

don't const'ref for bool

REPOSITORY
  R403 KMahjongg

REVISION DETAIL
  https://phabricator.kde.org/D20802

To: krippendorf, #kde_games, mlaurent
Cc: mlaurent, aacid, kde-games-devel, krippendorf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20190426/44feb71b/attachment.html>