D20831: Add fullscreen mode to kmahjongg

Albert Astals Cid noreply at phabricator.kde.org
Thu Apr 25 22:23:22 BST 2019


aacid added inline comments.

INLINE COMMENTS

> kmahjongg.cpp:173
>  
> +    QAction * fullscreen = actionCollection()->addAction(QStringLiteral("view_fullscreen"));
> +    fullscreen->setText(i18n("Fullscreen"));

use KStandardAction::fullScreen  ? https://api.kde.org/frameworks/kconfigwidgets/html/namespaceKStandardAction.html#a0e30d17570d5b886e97b1f2cf34ef900

that way you don't have to set the text (which is wrong) nor the icon yourself

REPOSITORY
  R403 KMahjongg

REVISION DETAIL
  https://phabricator.kde.org/D20831

To: krippendorf, #kde_games
Cc: aacid, kde-games-devel, krippendorf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20190425/583c46db/attachment.html>


More information about the kde-games-devel mailing list