D15534: Reduce wasted space for Klondike and Grandfather

Karl Ove Hufthammer noreply at phabricator.kde.org
Sat Sep 15 14:56:19 BST 2018


huftis created this revision.
Herald added a reviewer: KDE Games.
Herald added a subscriber: kde-games-devel.
huftis requested review of this revision.

REVISION SUMMARY
  Klondike and (especially) Grandfather reserves a lot of
  space at the bottom of the screen for long card piles.
  This results in very small cards, which makes the game
  uncomfortable to play, especially on smaller screens.
  This commmit reduces the space reserved at the bottom
  of the screen, which automatically enlarges the cards.
  Long piles don’t pose a problem, as KPat automatically
  compresses the cards to fit the screen. Even with the
  reduced space, the colours and numbers are still clearly
  visible, also in a ‘worst case’ scenario with very
  long piles.
  
  BUG: 378914

TEST PLAN
  Play Grandfather and Klondike before and after this patch.
  Note that the cards are much bigger after the patch
  and that the numbers and colours are still clearly visible.

REPOSITORY
  R410 KPatience

BRANCH
  reduce-wasted-space (branched from Applications/18.08)

REVISION DETAIL
  https://phabricator.kde.org/D15534

AFFECTED FILES
  grandf.cpp
  klondike.cpp

To: huftis, #kde_games
Cc: kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180915/558f1808/attachment-0001.html>


More information about the kde-games-devel mailing list