D16177: Fix segfaults / nullptr accesses.
Karl Ove Hufthammer
noreply at phabricator.kde.org
Sun Oct 14 16:25:30 BST 2018
huftis requested changes to this revision.
huftis added a comment.
This revision now requires changes to proceed.
In D16177#342429 <https://phabricator.kde.org/D16177#342429>, @shlomif wrote:
> Sorry - this should be applied against https://phabricator.kde.org/D16176 .
Thank you. I can confirm that this fixes the crashing bug in https://phabricator.kde.org/D16176.
With the fix, when the ‘demo mode’ runs out of valid moves to make, the demo mode seems to be correctly ended, i.e. the ‘Demo’ icon on the toolbar is deselected and changed back to a ‘Play’ icon. The only problem I can see is that (for the game in D16176 <https://phabricator.kde.org/D16176>) the status line nows says `Solver: Calculating...` after finishing the demo. It should be empty (as it is when actually running the demo), since it’s not actually doing any calculations. This should be fixed before commiting.
REPOSITORY
R410 KPatience
REVISION DETAIL
https://phabricator.kde.org/D16177
To: shlomif, #kde_games, huftis
Cc: huftis, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20181014/01286cb0/attachment.html>
More information about the kde-games-devel
mailing list