D15716: Suspicious use of signed arithmetic leads to negative index crash

Fabian Kosmale noreply at phabricator.kde.org
Wed Oct 10 07:36:59 BST 2018


fabiank accepted this revision.
fabiank added a comment.
This revision is now accepted and ready to land.


  Thanks for the patch. I can't reproduce the crash, but I agree with you that this is UB and should be fixed. I don't think that this changes how the RNG works, but even if it would, not crashing is more important.

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D15716

To: marten, #kde_games, fabiank
Cc: fabiank, shlomif, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20181010/435fda7c/attachment.html>


More information about the kde-games-devel mailing list