D16978: Reenable sounds in Kolf

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> game.cpp:450
> + m_factory(factory),
> + m_soundBlackHole(QStandardPaths::locate(QStandardPaths::AppDataLocation, "sounds/blackhole.wav")),
> + m_soundBlackHoleEject(QStandardPaths::locate(QStandardPaths::AppDataLocation, "sounds/blackholeeject.wav")),

Please fix the reordering warning this creates.

> game.h:267
>  
> +	KgSound m_soundBlackHole;
> +	KgSound m_soundBlackHoleEject;

Having member variables  public is "bad programming".

They should be in private, hidden behind a playSound(EnumValue ev)  or similar.

REPOSITORY
  R407 Kolf

REVISION DETAIL
  https://phabricator.kde.org/D16978

To: yurchor, #kde_games, ltoscano, arojas, aacid
Cc: sitter, aacid, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20181127/e2df19b2/attachment.html>