D12907: Implement wish 319522: Option to restart current game
Albert Astals Cid
noreply at phabricator.kde.org
Tue May 15 21:47:49 UTC 2018
aacid added inline comments.
INLINE COMMENTS
> gregormi wrote in ksudoku.cpp:550
> > also you should move this up and have it be action(bla)->setEnabled(game.isValid())
>
> oh, yes. I'll do that.
>
> > spacing seems off here
>
> This is because this file uses tabs instead of spaces. I would convert the file in a separate commit after the patch is accepted or should I do it at once?
Don't change the spacing policy of a file, you use whatever spacing it has, changing it is usually not a good idea.
REPOSITORY
R417 KSudoku
REVISION DETAIL
https://phabricator.kde.org/D12907
To: gregormi, #kde_games
Cc: aacid, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180515/45f32ae6/attachment.html>
More information about the kde-games-devel
mailing list