D12415: Use Freecell Solver for FreeCell and Simple Simon

[Fabian Kosmale]

fabiank added a comment.


  Sorry, I technically reviewed it already, but forgot to hit submit :-(. I'm happy with the current state of the code (sans that one copyright line), and the solver does a better job than the current one.
  
  So the only question is whether to add the library as a hard dependency. Personally, I'm fine with that, and unconditionally depending on it makes the kpat code easier to understand and maintain. The only question is whether this is an issue for the distributions. It shouldn't be an issue for Debian based ones, as they have it in their repos, and there exists a RPM which is already in some distros repos, but not in all. For instance, not in Fedora (contrary to what I initially thought).  @aacid :  Do you know anyone from the distro side who could chime in if adding the library would  pose an issue?

INLINE COMMENTS

> abstract_fc_solve_solver.h:2
> +/*
> + * Copyright (C) 2006-2009 Stephan Kulow <coolo at kde.org>
> + *

That copyright line is probably wrong, isn't it?

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D12415

To: shlomif, #kde_games, fabiank
Cc: kde-games-devel, aacid, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180514/393392c7/attachment.html>