D13815: cleaned up MemoryManager code
Fabian Kosmale
noreply at phabricator.kde.org
Sat Jun 30 16:49:04 UTC 2018
fabiank created this revision.
Restricted Application added a reviewer: KDE Games.
Restricted Application added a subscriber: kde-games-devel.
fabiank requested review of this revision.
REVISION SUMMARY
- Previously, it relied on allocating space behind an actual TREE and
then later accessing it via pointer arirthmetic. Now we have an actual
array as a member of the TREE. TREE is now also a template, templated
over the size of the array (which coincides with the pilecount of each
Solver)
- Alignment is now handled in the allocator, instead of ensuring that
every MemoryManager allocation preserves the alignment
- more typesafety in the allocation functions
TEST PLAN
- run Kpat manually, solver could still manage to solve games and determine solvability (at least to the extent it did before)
- memory usage stayed roughly the same
- Asan did not complain
REPOSITORY
R410 KPatience
BRANCH
cleanup_mm
REVISION DETAIL
https://phabricator.kde.org/D13815
AFFECTED FILES
CMakeLists.txt
patsolve/memory.cpp
patsolve/memory.h
patsolve/patsolve.cpp
patsolve/patsolve.h
To: fabiank, #kde_games
Cc: kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180630/0a039e68/attachment.html>
More information about the kde-games-devel
mailing list