D12912: Improve Hint and Solve action visibility and enabled state

Albert Astals Cid noreply at phabricator.kde.org
Mon Jun 4 21:46:39 UTC 2018


aacid added a comment.


  Well, you're the de-facto mainitaner now, so i'll have to trust you, i'd say if noone complains in a week, just commit this. (with the two small things fixed if possible)

INLINE COMMENTS

> ksudokugame.cpp:573
> +			return false;
> +        }
> +	}

the spacing here is a bit wonky :)

> ksudokugame.h:257
> +	 */
> +	bool allValuesSetAndUsable();
> +

this looks like it could be const

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D12912

To: gregormi, #kde_games
Cc: aacid, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180604/27fbae83/attachment.html>


More information about the kde-games-devel mailing list