D13815: cleaned up MemoryManager code

Albert Astals Cid noreply at phabricator.kde.org
Sat Jul 28 21:46:15 BST 2018


aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  I'm not going to pretend that i had time to read and understand the code, but if you think it's better and you'll fix any bugs that it may introduce, just go ahead and commit it :)

INLINE COMMENTS

> CMakeLists.txt:3
>  
>  cmake_minimum_required (VERSION 2.8.12 FATAL_ERROR)
> +

You need to increase cmake to 3.1 if you want the CMAKE_CXX_STANDARD

> memory.h:26
>  #include <sys/types.h>
> +#include <QtGlobal>
>  

What do you need from QtGlobal?

REPOSITORY
  R410 KPatience

BRANCH
  cleanup_mm

REVISION DETAIL
  https://phabricator.kde.org/D13815

To: fabiank, #kde_games, aacid
Cc: aacid, kde-games-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180728/7be0d5d0/attachment.html>


More information about the kde-games-devel mailing list