D11815: Refactor the Solver class

Albert Astals Cid noreply at phabricator.kde.org
Sun Apr 1 18:34:45 UTC 2018


aacid added a comment.


  I'm not totally sold on Solver being a template, imho

INLINE COMMENTS

> freecellsolver.cpp:402
>  
>      Nwpiles = 8;
>      Ntpiles = 4;

you already have this on the header?

> patsolve.cpp:986
> +
> +constexpr auto Nwpiles = 8;
> +constexpr auto Ntpiles = 4;

Why do you need all this lines?

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D11815

To: fabiank, #kde_games
Cc: aacid, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180401/7f291f65/attachment.html>


More information about the kde-games-devel mailing list