D11814: Getting rid of macros and dead code:

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> kcardscene.cpp:1253
> -
> -#if DEBUG_LAYOUT
> -    if ( !d->sizeHasBeenSet || !d->deck  )

This seems like something you would want to keep? (if it compiles)

> idiotsolver.cpp:299
>      for ( int i = 0; i < 4; ++i )
> -        Q_ASSERT( Wp[i] = &W[i][Wlen[i] - 1] );
> +        Q_ASSERT( Wp[i] == &W[i][Wlen[i] - 1] );
>      return ( ( Wlen[0] && higher( *Wp[pile], *Wp[0] ) ) ||

Are you really sure about this? This changes the assert totally

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D11814

To: fabiank, #kde_games
Cc: aacid, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180401/cce804dc/attachment-0001.html>