D8613: Properly show/hide preview dialog

Wolfgang Bauer noreply at phabricator.kde.org
Thu Nov 2 08:23:43 UTC 2017


wbauer created this revision.
wbauer added reviewers: KDE Games, ltoscano, chehrlic.

REVISION SUMMARY
  The visiblity of the preview dialog was not synced with the preview action in the main window. Also the preview image was not created when then same puzzle was opened after going back to the overview.
  Don't leak PuzzleComponent in GamePlay::loadPreview()
  
  This is a backport of commit https://phabricator.kde.org/R423:851870fbfae1b1e6c338d53ca3bdb59bbc732937 to the kdelibs4 based 17.08 branch.

TEST PLAN
  - compiles
  - preview menu option is now properly checked/unchecked
  - preview picture is correctly loaded/displayed if enabled

REPOSITORY
  R423 Palapeli

REVISION DETAIL
  https://phabricator.kde.org/D8613

AFFECTED FILES
  src/engine/gameplay.cpp
  src/window/mainwindow.cpp

To: wbauer, #kde_games, ltoscano, chehrlic
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20171102/dcde53bb/attachment.html>


More information about the kde-games-devel mailing list