Review Request 126023: Retrive the correct stone coordinates for the redo operation.

[Albert Astals Cid]

> On Nov. 11, 2015, 9:15 p.m., Albert Astals Cid wrote:
> > src/game/game.cpp, line 505
> > <https://git.reviewboard.kde.org/r/126023/diff/1/?file=416126#file416126line505>
> >
> >     This is very prone to breankig.
> >     
> >     The "White %1" string is translatable so some language could translate it to "%1 Something", and then it's broken.
> >     
> >     Please store the data as part of the UndoCommand class.

No answer to my fix it in more than one year, i'll discard this.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126023/#review88271
-----------------------------------------------------------


On Nov. 11, 2015, 10:45 a.m., Arseny Krasutsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126023/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 10:45 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 246642
>     http://bugs.kde.org/show_bug.cgi?id=246642
> 
> 
> Repository: kigo
> 
> 
> Description
> -------
> 
> Retrive the correct stone coordinates for the redo operation. Fixes https://bugs.kde.org/show_bug.cgi?id=246642
> 
> 
> Diffs
> -----
> 
>   src/game/game.cpp 3877cd2 
> 
> Diff: https://git.reviewboard.kde.org/r/126023/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arseny Krasutsky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170121/1eb9b09f/attachment.html>