Review Request 129957: Ask for saving on 'new game' and 'starting demo mode'

[Albert Astals Cid]

> On Feb. 21, 2017, 10:58 p.m., Albert Astals Cid wrote:
> > Should we also ask on loading and quiting?
> 
> Christian Krippendorf wrote:
>     In general we should. But I think this should be placed in a separate commit as it is not part of the bugreport. So after this one works and is online I would start working on further implementations.

Honestly i disagree, what you're doing here is not fixing the bug, but adding a "ask for saving on new game and starting demo mode" as you say on the title

And i find myself hard to convince we should ask for "new game" but not for "load".

If what we wanted was fixing the bug, probably easier should be just change "d" to "Ctrl+D" as shortcut for demo, i agree "d" seems a bit too trigger-easy for demo.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129957/#review102570
-----------------------------------------------------------


On Feb. 19, 2017, 6:55 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129957/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2017, 6:55 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 373245
>     http://bugs.kde.org/show_bug.cgi?id=373245
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> Ask for saving on 'new game' and 'starting demo mode'
> 
> 
> Diffs
> -----
> 
>   src/kmahjongg.h 8a5fa8e 
>   src/kmahjongg.cpp fe6eaaf 
> 
> Diff: https://git.reviewboard.kde.org/r/129957/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Initialize m_gameChanged variable in constructor
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/02/19/0390c2b3-e54e-498c-bc2d-2b29f2c4189c__0002-Initialize-m_gameChanged-variable-in-constructor.patch
> Don't ask for saving game when changed in demo mode
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/02/19/7f49c945-b826-4762-9c1f-4a10bc9948eb__0003-Don-t-ask-for-saving-game-when-changed-in-demo-mode.patch
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170222/c8137b11/attachment.html>