Review Request 129957: Ask for saving on 'new game' and 'starting demo mode'

[Christian Krippendorf]

> On Feb. 19, 2017, 6:15 nachm., Albert Astals Cid wrote:
> > Unchechekign the demo action i got the question asking me if i wanted to save the current game, doens't make much sense, no?

No, that really doesn't make sense. I added an additional patch file.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129957/#review102556
-----------------------------------------------------------


On Feb. 19, 2017, 6:55 nachm., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129957/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2017, 6:55 nachm.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 373245
>     http://bugs.kde.org/show_bug.cgi?id=373245
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> Ask for saving on 'new game' and 'starting demo mode'
> 
> 
> Diffs
> -----
> 
>   src/kmahjongg.h 8a5fa8e 
>   src/kmahjongg.cpp fe6eaaf 
> 
> Diff: https://git.reviewboard.kde.org/r/129957/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Initialize m_gameChanged variable in constructor
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/02/19/0390c2b3-e54e-498c-bc2d-2b29f2c4189c__0002-Initialize-m_gameChanged-variable-in-constructor.patch
> Don't ask for saving game when changed in demo mode
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/02/19/7f49c945-b826-4762-9c1f-4a10bc9948eb__0003-Don-t-ask-for-saving-game-when-changed-in-demo-mode.patch
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170219/d44cc677/attachment.html>