D7418: KF5 port: replace KStandardDirs with QStandardPaths

[Nemanja Hiršl]

nhirsl added a comment.


  Does this fix issue (crash) on startup?

INLINE COMMENTS

> texturehelper.cpp:73
> +		const QStringList fileNames = QDir(dir).entryList(QStringList() << QStringLiteral("*"), QDir::Files);
> +		Q_FOREACH (const QString& fileName, fileNames)
> +		{

A bit cleaner solution to this might be QDirIterator
Something like:
QDirIterator it(backgroundsFolder);
while (it.hasNext())

> texturehelper.cpp:77
> +			//create item for this brush
> +			const QPixmap pixmap = render(filePath);
> +			QStandardItem* item = new QStandardItem;

I would add here: 
if (!pixmap.isNull()) 
{
...
}

REPOSITORY
  R423 Palapeli

REVISION DETAIL
  https://phabricator.kde.org/D7418

To: chehrlic, #kde_games
Cc: nhirsl, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170819/6ccf6068/attachment.html>