D5627: Remove KDELibs4Support from KSudoku
Johan Ouwerkerk
noreply at phabricator.kde.org
Sat Apr 29 14:21:26 UTC 2017
ouwerkerk added a comment.
In https://phabricator.kde.org/D5627#105879, @ltoscano wrote:
> Do we really need the auto pointer? (just to check if that would bump some requirement, maybe just for one usage is not needed)
Of course not: in each case the appropriate type should be used instead. ;)
For `load()` the specific check is a bit different:
const QString errorMsg;
const Game game = doTheCall(... errorMsg)
if(!game.puzzle()) {
KMessageBox ...
}
REPOSITORY
R417 KSudoku
REVISION DETAIL
https://phabricator.kde.org/D5627
To: stikonas, #kde_games, ltoscano, ouwerkerk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170429/bfe479bb/attachment.html>
More information about the kde-games-devel
mailing list