D5627: Remove KDELibs4Support from KSudoku

[Johan Ouwerkerk]

ouwerkerk added inline comments.

INLINE COMMENTS

> ltoscano wrote in serializer.cpp:697
> I guess that errorMsg can be used here too.

Just make sure not to forget the `if()` guard!

> ltoscano wrote in serializer.cpp:710
> Same as above for errorMsg.

Just make sure not to forget the `if()` guard!

> serializer.cpp:404
> +	if ( url.isEmpty() ) {
> +		*errorMsg = i18n("Unable to download file: URL is empty.");
> +		return nullptr;

This needs an `if()` guard:

  if(errorMsg) {
      *errorMsg = i18n("Unable to download file: URL is empty.");
  }

> serializer.cpp:411
> +	if ( !tmpFile.open() ) {
> +		*errorMsg = i18n("Unable to create temporary file.");
> +		return nullptr;

This needs an `if()` guard:

  if(errorMsg) {
      *errorMsg = i18n("Unable to create temporary file.");
  }

> serializer.cpp:419
> +	if( downloadJob->error() ) {
> +		*errorMsg = i18n("Unable to download file.");
> +		return nullptr;

This needs an `if()` guard:

  if(errorMsg) {
      *errorMsg = i18n("Unable to download file.");
  }

> serializer.cpp:450
> +	if ( !tmpFile.open() ) {
> +		*errorMsg = i18n("Unable to create temporary file.");
> +		return Game();

This needs an `if()` guard:

  if(errorMsg) {
      *errorMsg = i18n("Unable to create temporary file.");
  }

> serializer.cpp:458
> +	if( downloadJob->error() ) {
> +		*errorMsg = i18n("Unable to download file.");
> +		return Game();

This needs an `if()` guard:

  if(errorMsg) {
      *errorMsg = i18n("Unable to download file.");
  }

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D5627

To: stikonas, #kde_games, ltoscano, ouwerkerk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170429/e01abc56/attachment-0001.html>