D5627: Remove KDELibs4Support from KSudoku

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> serializer.cpp:402
>  
>  SKGraph *Serializer::loadCustomShape(const QUrl &url, QWidget* window, QString *errorMsg) {
> +	if ( url.isEmpty() ) return nullptr;

When loadCustomShape is called, errorMsg is set to NULL, so setting it in the case of error may explode.

> serializer.cpp:697
> +	if ( !file.open() ) {
> +		KMessageBox::error(window, i18n("Unable to create temporary file."), i18n("Error Opening File"));
> +		return false;

I guess that errorMsg can be used here too.

> serializer.cpp:710
> +	{
> +		KMessageBox::error(window, i18n("Unable to upload file."), i18n("Error Writing File"));
> +		return false;

Same as above for errorMsg.

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D5627

To: stikonas, #kde_games, ltoscano, ouwerkerk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170429/993ae36d/attachment-0001.html>