D5627: Remove KDELibs4Support from KSudoku

[Johan Ouwerkerk]

ouwerkerk added inline comments.

INLINE COMMENTS

> ltoscano wrote in serializer.cpp:446
> Is some feedback required here?

What happens if you set `*errorMsg` ? ;)

Does that yield better UX than a `KMessageBox`?

> serializer.cpp:453
> +	if( downloadJob->error() ) {
> +		KMessageBox::error(window, i18n("Unable to download file."), i18n("Error Reading File"));
> +		return Game();

Considering tosky's earlier comment above:

What happens if you set `*errorMsg` ? ;) Does that yield better UX than a `KMessageBox`?

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D5627

To: stikonas, #kde_games, ltoscano, ouwerkerk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170429/f3375aa4/attachment.html>