D5627: Remove KDELibs4Support from KSudoku

Andrius Štikonas noreply at phabricator.kde.org
Fri Apr 28 11:37:18 UTC 2017


stikonas added inline comments.

INLINE COMMENTS

> ouwerkerk wrote in serializer.cpp:402
> The body of this function is basically the same as the next one which returns a `Game` instead. Maybe we should extract and consolidate the bulk of this to a new shared function?

Maybe do refactoring in a separate patch? This needs to fix calls to these functions too then... But yeah, that sounds good.

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D5627

To: stikonas, #kde_games, ltoscano, ouwerkerk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170428/037b3fa6/attachment.html>


More information about the kde-games-devel mailing list