D5626: Initial cleanup of the debug statements (qDebug, dbk, dbe)
Luigi Toscano
noreply at phabricator.kde.org
Thu Apr 27 22:03:09 UTC 2017
ltoscano created this revision.
Restricted Application added a reviewer: KDE Games.
Restricted Application added a subscriber: KDE Games.
REVISION SUMMARY
There was a combination of qDebug, kDebug and custom macros
which redirected to qDebug, standard error or standard output.
This is the first attempt to unify all of the above with the usage
of Qt categorized logging. Fixed in the patch:
- direct usage of qDebug;
- kDebug though the dbk macro;
- standard error through the dbe macro.
The levels for dbk/dbe messages have been aligned with the level
of the respective macros.
Few standard output/dbo macros have been cleaned as well, but many
are still used. At least their usage is confined to one file only
(src/generator/sudokuboard.cpp). Some of those messages produces
formatted output, so they may require overloads of the << operator,
if they need to be kept.
TEST PLAN
Compiles.
REPOSITORY
R417 KSudoku
BRANCH
clean-debug-1
REVISION DETAIL
https://phabricator.kde.org/D5626
AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
src/generator/cagegenerator.cpp
src/generator/debug.h
src/generator/dlxsolver.cpp
src/generator/mathdokugenerator.cpp
src/generator/sudokuboard.cpp
src/gui/gamevariants.cpp
src/gui/ksudoku.cpp
src/gui/ksudokugame.cpp
src/gui/views/renderer.cpp
src/gui/views/view2d.cpp
To: ltoscano, ouwerkerk, stikonas, #kde_games
Cc: #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170427/834783ac/attachment-0001.html>
More information about the kde-games-devel
mailing list