D5544: Port usage of KUrl and friends to equivalent constructs with QUrl.

Johan Ouwerkerk noreply at phabricator.kde.org
Thu Apr 27 19:16:12 UTC 2017


ouwerkerk updated this revision to Diff 13886.
ouwerkerk added a comment.


  Fix: crash on opening a custom game variant.
  
  KUrl accepts raw file paths, but QUrl doesn't. 
  Use QUrl::fromLocalFile() to fix the crash.
  Also make sure to not do hacky things with raw file paths when Qt supplies perfectly good APIs for that purpose already.
  (Note: the entire function should probably be updated to use Qt APIs instead of manual fiddling with file & directory paths.)

REPOSITORY
  R417 KSudoku

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5544?vs=13710&id=13886

BRANCH
  port-to-qurl

REVISION DETAIL
  https://phabricator.kde.org/D5544

AFFECTED FILES
  src/gui/gamevariants.cpp
  src/gui/gamevariants.h
  src/gui/ksudoku.cpp
  src/gui/ksudoku.h
  src/gui/ksudokugame.cpp
  src/gui/ksudokugame.h
  src/gui/serializer.cpp
  src/gui/serializer.h
  src/main.cpp

To: ouwerkerk, #kde_games, ltoscano
Cc: ltoscano, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170427/3fae3602/attachment.html>


More information about the kde-games-devel mailing list