D5544: Port usage of KUrl and friends to equivalent constructs with QUrl.

Luigi Toscano noreply at phabricator.kde.org
Sun Apr 23 15:23:40 UTC 2017


ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


  The program crashes when you select a non-standard game (which I guess comes from wrong reading of some URL). Porting to QUrl requires a bit of investigation as the behavior is a bit different.
  
  Please note that they may be other crashes or other unexpected behaviors; a deeper testing which touches all the code which is changed here is needed.
  
  Example of crash:
  
    #6  0x000055e83b8bfcbc in QVector<int>::size() const ()
    #7  0x000055e83b8ce5d0 in ksudoku::Puzzle::hasSolution() const ()
    #8  0x000055e83b8de721 in ksudoku::WelcomeScreen::generatePuzzle() ()
    #9  0x000055e83b8dfae3 in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (ksudoku::WelcomeScreen::*)()>::call(void (ksudoku::WelcomeScreen::*)(), ksudoku::WelcomeScreen*, void**) ()
    #10 0x000055e83b8dfa75 in void QtPrivate::FunctionPointer<void (ksudoku::WelcomeScreen::*)()>::call<QtPrivate::List<>, void>(void (ksudoku::WelcomeScreen::*)(), ksudoku::WelcomeScreen*, void**) ()
    #11 0x000055e83b8df981 in QtPrivate::QSlotObject<void (ksudoku::WelcomeScreen::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) ()
    #12 0x00007f89c5ef295e in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
    #13 0x00007f89c7559135 in QAbstractItemView::doubleClicked(QModelIndex const&) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    #14 0x00007f89c756686a in QAbstractItemView::mouseDoubleClickEvent(QMouseEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
    [...]

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D5544

To: ouwerkerk, #kde_games, ltoscano
Cc: ltoscano, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170423/23fe97d0/attachment.html>


More information about the kde-games-devel mailing list