Review Request 130102: [Ksirk frameworks] Remove dependency on KDELibs4Support

Nemanja Hirsl nemhirsl at gmail.com
Sun Apr 23 14:14:12 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130102/
-----------------------------------------------------------

(Updated April 23, 2017, 2:14 p.m.)


Review request for KDE Games.


Changes
-------

Fixing scale and unnecessary change for KMessageBox


Repository: ksirk


Description
-------

[Ksirk frameworks] Remove dependency on KDELibs4Support


Diffs (updated)
-----

  CMakeLists.txt 1eff2fe 
  ksirk/CMakeLists.txt 4448f77 
  ksirk/Dialogs/InvasionSlider.cpp b74c55c 
  ksirk/Dialogs/jabbergameui.cpp 0cca7bc 
  ksirk/Dialogs/newGameDialog.ui 1b30a53 
  ksirk/Dialogs/newGameDialogImpl.cpp d091ac1 
  ksirk/Dialogs/newGameSummaryWidget.cpp e911145 
  ksirk/Dialogs/qplayersetupdialog.ui 430dee5 
  ksirk/Dialogs/tcpconnectwidget.ui f343310 
  ksirk/GameLogic/aiColsonPlayer.cpp a286678 
  ksirk/GameLogic/country.cpp 8d84368 
  ksirk/GameLogic/dice.h 2ff2e6d 
  ksirk/GameLogic/gameautomaton.h f55f649 
  ksirk/GameLogic/gameautomaton.cpp 25d4ee6 
  ksirk/GameLogic/onu.cpp 838b89b 
  ksirk/Jabber/jabberbytestream.cpp 6989b8f 
  ksirk/Jabber/kmessagejabber.cpp d0645a6 
  ksirk/Sprites/animsprite.cpp 7162042 
  ksirk/Sprites/backgnd.h 8633303 
  ksirk/decoratedgameframe.cpp c954110 
  ksirk/fightArena.h 16312fe 
  ksirk/fightArena.cpp e03048e 
  ksirk/gestionSprites.cpp 0bbdcb6 
  ksirk/iris/src/irisnet/corelib/objectsession.cpp 03b4f74 
  ksirk/iris/src/xmpp/base64/base64.cpp 3e2023d 
  ksirk/iris/src/xmpp/cutestuff/httpconnect.cpp 204c274 
  ksirk/iris/src/xmpp/cutestuff/httppoll.cpp 4e05ba9 
  ksirk/iris/src/xmpp/xmpp-im/xmpp_vcard.cpp cdbd49b 
  ksirk/iris/src/xmpp/xmpp-im/xmpp_xmlcommon.cpp 29e4e1f 
  ksirk/kgamewin.h b3dadb7 
  ksirk/kgamewin.cpp c11006f 
  ksirk/kgamewinslots.cpp d98a614 
  ksirk/krightdialog.h c3da2b7 
  ksirk/krightdialog.cpp cbac45c 
  ksirk/ksirkConfigDialog.cpp c3e2ff0 
  ksirk/mainMenu.cpp bcb2a9d 
  ksirk/newgamesetup.cpp b2365c4 
  ksirkskineditor/CMakeLists.txt ecf2d78 
  ksirkskineditor/ksirkSkinEditorConfigDialog.cpp bf00a82 
  ksirkskineditor/ksirkcontinentdefinition.ui 76053f3 
  ksirkskineditor/ksirkcountrydefinition.ui e7a2f68 
  ksirkskineditor/ksirkskindefinition.ui 54eee30 
  ksirkskineditor/ksirkspritesdefinition.ui ca97e28 
  ksirkskineditor/mainwindow.h c778c60 
  ksirkskineditor/mainwindow.cpp e876b84 
  ksirkskineditor/onu.h 3af5a3c 

Diff: https://git.reviewboard.kde.org/r/130102/diff/


Testing
-------

Gameplay.
Network game was not tested


Thanks,

Nemanja Hirsl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170423/f8263faa/attachment.html>


More information about the kde-games-devel mailing list