Review Request 130100: [Ksirk frameworks] Port kDebug to qCDebug
Nemanja Hirsl
nemhirsl at gmail.com
Sat Apr 22 23:36:04 UTC 2017
> On April 22, 2017, 9:54 p.m., Luigi Toscano wrote:
> > Sent without a ship it, and with a bad format for the commit message.
>
> Luigi Toscano wrote:
> Change reverted. Please discuss this on IRC before sending, the change was not complete:
> - a lot of kDebug under ksirk/Jabber/ ; they have not been not converted by the script because they had a category, but they could have been easily spotted with a manual check.
> - the commit message should have been a bit different. It was:
> -----------------
> REVIEW: 130100
> [Ksirk frameworks] Port kDebug to qCDebug
> All logs converted
> ----------------
> Things to change:
> * it should respect the git guidelines (first relevant summary line, max 55/60 characters+blank line+ rest of commit message. Here the blank line is missing.
> * the first line should contain the description, so "Port kDebu to qCDebug"; the REVIEW is an internal detail and should go in the body of the commit message.
> * [Ksirk frameworks] is not needed. This is the ksirk repository, frameworks is part of the context.
> A possible commit message can be:
> ------------------
> Port kDebug to qCDebug
>
> All logs converted
> REVIEW: 130100
> ------------------
>
>
> I want to think that you pushed this by mistake. So please reopen this and discuss again, I'm also on IRC.
>
> Nemanja Hirsl wrote:
> Please, do not revert changes
>
> There are too many files to manage for multiple reviews and a lot of conflicts to resolve between them.
> Once everything is in place, we can work on details.
> More important changes are comming.
>
> Luigi Toscano wrote:
> It's already reverted, so let's work on fixing that first. The other change will come later, after the first one is accepted.
>
> Multiple changes should not be a problem: git can handle them for you. You can rewrite your local history, create multiple branches. That's not a problem.
>
> Luigi Toscano wrote:
> Just to be clear: if you ask for reviews, you should be ready to deal with the reviews. You can skip the review and push directly, we don't forbid this, sure, but then there are other consequences that should be dealt with as well: ensure that your changes don't conflict with other changes pushed to the same repository (because then other people could fix on the fly the mistakes), ensure that the build.kde.org and so on.
>
> Nemanja Hirsl wrote:
> All right.
> Can you finish this one then, update what's needed?
>
> Luigi Toscano wrote:
> I will do it for the sake of finishing this porting task, but it's not how it should work.
Thanks!
- Nemanja
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130100/#review103102
-----------------------------------------------------------
On April 22, 2017, 9:52 p.m., Nemanja Hirsl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130100/
> -----------------------------------------------------------
>
> (Updated April 22, 2017, 9:52 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: ksirk
>
>
> Description
> -------
>
> [Ksirk frameworks] Port kDebug to qCDebug
>
>
> Diffs
> -----
>
> CMakeLists.txt 54910ed
> ksirk/CMakeLists.txt 260da6a
> ksirk/Dialogs/InvasionSlider.cpp 041992f
> ksirk/Dialogs/jabbergameui.cpp dd0e9a0
> ksirk/Dialogs/joingame.cpp c00c88a
> ksirk/Dialogs/kplayersetupwidget.cpp b55e170
> ksirk/Dialogs/kwaitedplayersetupdialog.cpp a51509e
> ksirk/Dialogs/newGameDialogImpl.cpp 80c8717
> ksirk/Dialogs/newGameSummaryWidget.cpp 8031cc9
> ksirk/Dialogs/restartOrExitDialogImpl.cpp aad96f9
> ksirk/Dialogs/tcpconnectwidget.cpp c3cf605
> ksirk/GameLogic/KsirkChatDelegate.cpp dbbbd0b
> ksirk/GameLogic/KsirkChatItem.cpp 2d079dd
> ksirk/GameLogic/KsirkChatModel.cpp 1e3cd03
> ksirk/GameLogic/aiColsonPlayer.cpp 19829fb
> ksirk/GameLogic/aiplayer.cpp 50c9757
> ksirk/GameLogic/continent.cpp b97713a
> ksirk/GameLogic/country.cpp eae46c9
> ksirk/GameLogic/eventslistproperty.cpp 9553514
> ksirk/GameLogic/gameautomaton.cpp ba41d50
> ksirk/GameLogic/goal.cpp b4a515e
> ksirk/GameLogic/onu.cpp 30a9d9c
> ksirk/GameLogic/player.cpp 8bc8384
> ksirk/Jabber/jabberaccount.cpp b0579cc
> ksirk/Jabber/jabberbasecontact.cpp de41445
> ksirk/Jabber/jabberbookmarks.cpp c0d1054
> ksirk/Jabber/jabberbytestream.cpp 39ce88f
> ksirk/Jabber/jabbercapabilitiesmanager.cpp 514e119
> ksirk/Jabber/jabberclient.cpp ca5e9f5
> ksirk/Jabber/jabberconnector.cpp a41b384
> ksirk/Jabber/jabbercontact.cpp 7458fdb
> ksirk/Jabber/jabbercontactpool.cpp 4496353
> ksirk/Jabber/jabbergroupcontact.cpp 2cafdf9
> ksirk/Jabber/jabbergroupmembercontact.cpp b5df565
> ksirk/Jabber/jabberprotocol.cpp 2a71897
> ksirk/Jabber/jabberresource.cpp 2ed0732
> ksirk/Jabber/jabberresourcepool.cpp c6b4f97
> ksirk/Jabber/kmessagejabber.h fb08076
> ksirk/Jabber/kmessagejabber.cpp cdd1b5d
> ksirk/Jabber/privacylist.cpp 67f9139
> ksirk/Jabber/privacylistitem.cpp 40f7569
> ksirk/Jabber/privacymanager.cpp 02b2f4d
> ksirk/SaveLoad/ksirkgamexmlhandler.cpp 209d595
> ksirk/Sprites/animsprite.cpp 3b2c982
> ksirk/Sprites/animspritesgroup.cpp 1adb2a0
> ksirk/Sprites/animspriteslist.h 8084ce5
> ksirk/Sprites/animspriteslist.cpp cab46ce
> ksirk/Sprites/animspritespool.cpp 5fceca5
> ksirk/Sprites/arrowsprite.cpp 7e7646b
> ksirk/Sprites/backgnd.cpp 736fc30
> ksirk/Sprites/cannonsprite.cpp 3e99d3c
> ksirk/decoratedgameframe.cpp 028e435
> ksirk/fightArena.cpp de17ee1
> ksirk/gestionSprites.cpp 90a3fb9
> ksirk/kgamewin.cpp 50795e0
> ksirk/kgamewinslots.cpp cb5d210
> ksirk/krightdialog.cpp 8f0095c
> ksirk/ksirkConfigDialog.cpp c84b181
> ksirk/main.cpp 519dfe7
> ksirk/mainMenu.cpp 935617b
> ksirk/newgamesetup.cpp 6384c09
>
> Diff: https://git.reviewboard.kde.org/r/130100/diff/
>
>
> Testing
> -------
>
> Build and gameplay.
> Logs are available with the category org.kde.ksirk
> Default log level is debug.
>
>
> Thanks,
>
> Nemanja Hirsl
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170422/7a49a32f/attachment.html>
More information about the kde-games-devel
mailing list