D5544: Port usage of KUrl and friends to equivalent constructs with QUrl.

[Luigi Toscano]

ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


  There are few errors; following the chat on IRC, I think you need a development environment:
  
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/ksudoku.cpp: In member function ‘void KSudoku::updateShapesList()’:
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/ksudoku.cpp:220:72: error: no matching function for call to ‘ksudoku::CustomGame::CustomGame(QString&, QString&, ksudoku::GameVariantCollection*&)’
       variant = new CustomGame(variantName, variantDataPath, m_gameVariants);
                                                                            ^
    In file included from /mnt/kde/git/kde/kdegames/ksudoku/src/gui/ksudoku.cpp:73:0:
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/gamevariants.h:170:2: note: candidate: ksudoku::CustomGame::CustomGame(const QString&, const QUrl&, ksudoku::GameVariantCollection*)
      CustomGame(const QString& name, const QUrl& url, GameVariantCollection* collection=0);
      ^~~~~~~~~~
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/gamevariants.h:170:2: note:   no known conversion for argument 2 from ‘QString’ to ‘const QUrl&’
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/gamevariants.h:168:7: note: candidate: ksudoku::CustomGame::CustomGame(const ksudoku::CustomGame&)
     class CustomGame : public GameVariant {
           ^~~~~~~~~~
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/gamevariants.h:168:7: note:   candidate expects 1 argument, 3 provided
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/gamevariants.h:168:7: note: candidate: ksudoku::CustomGame::CustomGame(ksudoku::CustomGame&&)
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/gamevariants.h:168:7: note:   candidate expects 1 argument, 3 provided
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/ksudoku.cpp: In member function ‘virtual void KSudoku::dragEnterEvent(QDragEnterEvent*)’:
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/ksudoku.cpp:631:37: error: request for member ‘hasUrls’ in ‘event->QDragEnterEvent::<anonymous>.QDragMoveEvent::<anonymous>.QDropEvent::mimeData()’, which is of pointer type ‘const QMimeData*’ (maybe you meant to use ‘->’ ?)
         event->accept(event->mimeData().hasUrls());
                                         ^~~~~~~
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/ksudoku.cpp: In member function ‘virtual void KSudoku::dropEvent(QDropEvent*)’:
    /mnt/kde/git/kde/kdegames/ksudoku/src/gui/ksudoku.cpp:636:43: error: conversion from ‘const QMimeData*’ to non-scalar type ‘const QMimeData’ requested
         const QMimeData data = event->mimeData();
                                ~~~~~~~~~~~~~~~^~

REPOSITORY
  R417 KSudoku

REVISION DETAIL
  https://phabricator.kde.org/D5544

To: ouwerkerk, #kde_games, ltoscano
Cc: ltoscano, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170422/3042a6e8/attachment-0001.html>