Review Request 130098: [Ksirk frameworks] Logging port from kDebug to qCDebug

Nemanja Hirsl nemhirsl at gmail.com
Sat Apr 22 14:30:38 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130098/
-----------------------------------------------------------

(Updated April 22, 2017, 2:30 p.m.)


Review request for KDE Games.


Changes
-------

changing logksirk -> "org.kde.ksirk". 
Cmake cleanup


Repository: ksirk


Description
-------

[Ksirk frameworks] Logging port from kDebug to qCDebug


Diffs (updated)
-----

  ksirk/CMakeLists.txt 260da6a 
  ksirk/Dialogs/InvasionSlider.cpp 041992f 
  ksirk/Dialogs/jabbergameui.cpp dd0e9a0 
  ksirk/Dialogs/joingame.cpp c00c88a 
  ksirk/Dialogs/kplayersetupwidget.cpp b55e170 
  ksirk/Dialogs/kwaitedplayersetupdialog.cpp a51509e 
  ksirk/Dialogs/newGameDialogImpl.cpp 80c8717 
  ksirk/Dialogs/newGameSummaryWidget.cpp 8031cc9 
  ksirk/Dialogs/restartOrExitDialogImpl.cpp aad96f9 
  ksirk/Dialogs/tcpconnectwidget.cpp c3cf605 
  ksirk/GameLogic/KsirkChatDelegate.cpp dbbbd0b 
  ksirk/GameLogic/KsirkChatItem.cpp 2d079dd 
  ksirk/GameLogic/KsirkChatModel.cpp 1e3cd03 
  ksirk/GameLogic/aiColsonPlayer.cpp 19829fb 
  ksirk/GameLogic/aiplayer.cpp 50c9757 
  ksirk/GameLogic/continent.cpp b97713a 
  ksirk/GameLogic/country.cpp eae46c9 
  ksirk/GameLogic/eventslistproperty.cpp 9553514 
  ksirk/GameLogic/gameautomaton.cpp ba41d50 
  ksirk/GameLogic/goal.cpp b4a515e 
  ksirk/GameLogic/onu.cpp 30a9d9c 
  ksirk/GameLogic/player.cpp 8bc8384 
  ksirk/Jabber/jabberaccount.cpp b0579cc 
  ksirk/Jabber/jabberbasecontact.cpp de41445 
  ksirk/Jabber/jabberbookmarks.cpp c0d1054 
  ksirk/Jabber/jabberbytestream.cpp 39ce88f 
  ksirk/Jabber/jabbercapabilitiesmanager.cpp 514e119 
  ksirk/Jabber/jabberclient.cpp ca5e9f5 
  ksirk/Jabber/jabberconnector.cpp a41b384 
  ksirk/Jabber/jabbercontact.cpp 7458fdb 
  ksirk/Jabber/jabbercontactpool.cpp 4496353 
  ksirk/Jabber/jabbergroupcontact.cpp 2cafdf9 
  ksirk/Jabber/jabbergroupmembercontact.cpp b5df565 
  ksirk/Jabber/jabberprotocol.cpp 2a71897 
  ksirk/Jabber/jabberresource.cpp 2ed0732 
  ksirk/Jabber/jabberresourcepool.cpp c6b4f97 
  ksirk/Jabber/kmessagejabber.h fb08076 
  ksirk/Jabber/kmessagejabber.cpp cdd1b5d 
  ksirk/Jabber/privacylist.cpp 67f9139 
  ksirk/Jabber/privacylistitem.cpp 40f7569 
  ksirk/Jabber/privacymanager.cpp 02b2f4d 
  ksirk/SaveLoad/ksirkgamexmlhandler.cpp 209d595 
  ksirk/Sprites/animsprite.cpp 3b2c982 
  ksirk/Sprites/animspritesgroup.cpp 1adb2a0 
  ksirk/Sprites/animspriteslist.h 8084ce5 
  ksirk/Sprites/animspriteslist.cpp cab46ce 
  ksirk/Sprites/animspritespool.cpp 5fceca5 
  ksirk/Sprites/arrowsprite.cpp 7e7646b 
  ksirk/Sprites/backgnd.cpp 736fc30 
  ksirk/Sprites/cannonsprite.cpp 3e99d3c 
  ksirk/decoratedgameframe.cpp 028e435 
  ksirk/fightArena.cpp de17ee1 
  ksirk/gestionSprites.cpp 90a3fb9 
  ksirk/iris/src/CMakeLists.txt da2a0ff 
  ksirk/iris/src/xmpp/sasl/digestmd5response.cpp 483690d 
  ksirk/iris/src/xmpp/xmpp-core/compressionhandler.cpp e3f0add 
  ksirk/iris/src/xmpp/xmpp-core/simplesasl.cpp cc9fac4 
  ksirk/iris/src/xmpp/xmpp-im/client.cpp 9b51302 
  ksirk/kgamewin.cpp 50795e0 
  ksirk/kgamewinslots.cpp cb5d210 
  ksirk/krightdialog.cpp 8f0095c 
  ksirk/ksirkConfigDialog.cpp c84b181 
  ksirk/ksirkdebug.h PRE-CREATION 
  ksirk/ksirkdebug.cpp PRE-CREATION 
  ksirk/main.cpp 519dfe7 
  ksirk/mainMenu.cpp 935617b 
  ksirk/newgamesetup.cpp 6384c09 

Diff: https://git.reviewboard.kde.org/r/130098/diff/


Testing
-------

After applyng convert-qkdebug-to-qcdebug.sh, a few changes made in order to compile succesfully.

Application tested and logs are available: 
./ksirk
logksirk: Hello KsirK
logksirk: Creating main window
...


Thanks,

Nemanja Hirsl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170422/973244ef/attachment.html>


More information about the kde-games-devel mailing list