Review Request 130098: [Ksirk frameworks] Logging port from kDebug to qCDebug

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130098/#review103089
-----------------------------------------------------------




ksirk/iris/src/CMakeLists.txt (line 79)
<https://git.reviewboard.kde.org/r/130098/#comment68591>

    I'd suggest to define a different category for the files under ksirk/iris.
    Or maybe: leave them apart for now (just move to qDebug), to make it easier the sync with the code from upstream.



ksirk/ksirkdebug.cpp (line 21)
<https://git.reviewboard.kde.org/r/130098/#comment68592>

    logksirk->org.kde.ksirk


- Luigi Toscano


On Apr. 22, 2017, 2:27 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130098/
> -----------------------------------------------------------
> 
> (Updated Apr. 22, 2017, 2:27 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksirk
> 
> 
> Description
> -------
> 
> [Ksirk frameworks] Logging port from kDebug to qCDebug
> 
> 
> Diffs
> -----
> 
>   ksirk/ksirkdebug.h PRE-CREATION 
>   ksirk/ksirkdebug.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/130098/diff/
> 
> 
> Testing
> -------
> 
> After applyng convert-qkdebug-to-qcdebug.sh, a few changes made in order to compile succesfully.
> 
> Application tested and logs are available: 
> ./ksirk
> logksirk: Hello KsirK
> logksirk: Creating main window
> ...
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170422/bfadacb2/attachment-0001.html>