Review Request 130095: [Ksirk frameworks] Removal of KDELibs4Support

[Nemanja Hirsl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130095/#review103080
-----------------------------------------------------------




ksirk/GameLogic/onu.cpp (line 62)
<https://git.reviewboard.kde.org/r/130095/#comment68578>

    Is this needed in KF5 at all?



ksirk/Jabber/jabberbytestream.cpp (line 42)
<https://git.reviewboard.kde.org/r/130095/#comment68579>

    Is this the right way to port KSocketFactory?



ksirk/gestionSprites.cpp (line 242)
<https://git.reviewboard.kde.org/r/130095/#comment68577>

    Just comment out assigned but not used variables.
    It might be the case there is a bug in calculating positions, so I'm keeping the code for the refference.



ksirk/iris/src/irisnet/corelib/objectsession.cpp (line 116)
<https://git.reviewboard.kde.org/r/130095/#comment68580>

    Not sure if this is right?



ksirk/iris/src/xmpp/cutestuff/httppoll.cpp (line 152)
<https://git.reviewboard.kde.org/r/130095/#comment68581>

    Is this OK?



ksirk/kgamewinslots.cpp (line 1105)
<https://git.reviewboard.kde.org/r/130095/#comment68576>

    Didn't try this. 
    Is this a proper way to port?


- Nemanja Hirsl


On April 21, 2017, 12:32 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130095/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 12:32 p.m.)
> 
> 
> Review request for KDE Games, Luigi Toscano and Frederik Schwarzer.
> 
> 
> Repository: ksirk
> 
> 
> Description
> -------
> 
> [Ksirk frameworks] Remove KDELibs4Support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 54910ed 
>   ksirk/CMakeLists.txt 260da6a 
>   ksirk/Dialogs/InvasionSlider.cpp 041992f 
>   ksirk/Dialogs/jabbergameui.cpp dd0e9a0 
>   ksirk/Dialogs/joingame.cpp c00c88a 
>   ksirk/Dialogs/kplayersetupwidget.cpp b55e170 
>   ksirk/Dialogs/kwaitedplayersetupdialog.cpp a51509e 
>   ksirk/Dialogs/newGameDialog.ui 1b30a53 
>   ksirk/Dialogs/newGameDialogImpl.cpp 80c8717 
>   ksirk/Dialogs/newGameSummaryWidget.cpp 8031cc9 
>   ksirk/Dialogs/qplayersetupdialog.ui 430dee5 
>   ksirk/Dialogs/restartOrExitDialogImpl.cpp aad96f9 
>   ksirk/Dialogs/tcpconnectwidget.cpp c3cf605 
>   ksirk/Dialogs/tcpconnectwidget.ui f343310 
>   ksirk/GameLogic/KsirkChatDelegate.cpp dbbbd0b 
>   ksirk/GameLogic/KsirkChatItem.cpp 2d079dd 
>   ksirk/GameLogic/KsirkChatModel.cpp 1e3cd03 
>   ksirk/GameLogic/aiColsonPlayer.cpp 19829fb 
>   ksirk/GameLogic/aiplayer.cpp 50c9757 
>   ksirk/GameLogic/continent.cpp b97713a 
>   ksirk/GameLogic/country.cpp eae46c9 
>   ksirk/GameLogic/dice.h 2ff2e6d 
>   ksirk/GameLogic/eventslistproperty.cpp 9553514 
>   ksirk/GameLogic/gameautomaton.h f55f649 
>   ksirk/GameLogic/gameautomaton.cpp ba41d50 
>   ksirk/GameLogic/goal.cpp b4a515e 
>   ksirk/GameLogic/onu.cpp 30a9d9c 
>   ksirk/GameLogic/player.cpp 8bc8384 
>   ksirk/Jabber/jabberbytestream.cpp 39ce88f 
>   ksirk/Jabber/jabberclient.cpp ca5e9f5 
>   ksirk/Jabber/jabberconnector.cpp a41b384 
>   ksirk/Jabber/kmessagejabber.cpp cdd1b5d 
>   ksirk/Jabber/privacylist.cpp 67f9139 
>   ksirk/Jabber/privacylistitem.cpp 40f7569 
>   ksirk/Jabber/privacymanager.cpp 02b2f4d 
>   ksirk/SaveLoad/ksirkgamexmlhandler.cpp 209d595 
>   ksirk/Sprites/animsprite.cpp 3b2c982 
>   ksirk/Sprites/animspritesgroup.cpp 1adb2a0 
>   ksirk/Sprites/animspriteslist.h 8084ce5 
>   ksirk/Sprites/animspritespool.cpp 5fceca5 
>   ksirk/Sprites/arrowsprite.cpp 7e7646b 
>   ksirk/Sprites/backgnd.h 8633303 
>   ksirk/Sprites/backgnd.cpp 736fc30 
>   ksirk/Sprites/cannonsprite.cpp 3e99d3c 
>   ksirk/decoratedgameframe.cpp 028e435 
>   ksirk/fightArena.h 16312fe 
>   ksirk/fightArena.cpp de17ee1 
>   ksirk/gestionSprites.cpp 90a3fb9 
>   ksirk/iris/src/irisnet/corelib/objectsession.cpp 03b4f74 
>   ksirk/iris/src/xmpp/base64/base64.cpp 3e2023d 
>   ksirk/iris/src/xmpp/cutestuff/httpconnect.cpp 204c274 
>   ksirk/iris/src/xmpp/cutestuff/httppoll.cpp 4e05ba9 
>   ksirk/iris/src/xmpp/xmpp-im/xmpp_vcard.cpp cdbd49b 
>   ksirk/iris/src/xmpp/xmpp-im/xmpp_xmlcommon.cpp 29e4e1f 
>   ksirk/kgamewin.h b3dadb7 
>   ksirk/kgamewin.cpp 50795e0 
>   ksirk/kgamewinslots.cpp cb5d210 
>   ksirk/krightdialog.h c3da2b7 
>   ksirk/krightdialog.cpp 8f0095c 
>   ksirk/ksirkConfigDialog.cpp c84b181 
>   ksirk/mainMenu.cpp 935617b 
>   ksirk/newgamesetup.cpp 6384c09 
>   ksirkskineditor/CMakeLists.txt ecf2d78 
>   ksirkskineditor/ksirkSkinEditorConfigDialog.cpp bf00a82 
>   ksirkskineditor/ksirkcontinentdefinition.ui 76053f3 
>   ksirkskineditor/ksirkcountrydefinition.ui e7a2f68 
>   ksirkskineditor/ksirkskindefinition.ui 54eee30 
>   ksirkskineditor/ksirkspritesdefinition.ui ca97e28 
>   ksirkskineditor/mainwindow.h c778c60 
>   ksirkskineditor/mainwindow.cpp e876b84 
>   ksirkskineditor/onu.h 3af5a3c 
> 
> Diff: https://git.reviewboard.kde.org/r/130095/diff/
> 
> 
> Testing
> -------
> 
> - Didn't test Jabber funcionality, although some changes were made there.
> - Game play works.
> - KDE New Stuff doesn't work neither in frameworks nor master. Has to be fixed.
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20170421/ab5cf37f/attachment.html>