[Kde-games-devel] Review Request 127989: Fix game startup.

[Frederik Schwarzer]

> On May 23, 2016, 9:06 p.m., Albert Astals Cid wrote:
> > I don't understand how this fixes a crash because of a missing import. Can you clarify?

There was some misunderstanding there, which I did not see due to not experiencing the crash at all.

The crash seem to have been caused by packaging issues.

The patch goes against the frameworks branch fixing issues with a broken startup dialogue and missing graphics.
Since I am not familiar with QML, I cannot comment on the specifics. But it fixes the issue.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127989/#review95727
-----------------------------------------------------------


On May 22, 2016, 5:27 p.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127989/
> -----------------------------------------------------------
> 
> (Updated May 22, 2016, 5:27 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 341777
>     http://bugs.kde.org/show_bug.cgi?id=341777
> 
> 
> Repository: kreversi
> 
> 
> Description
> -------
> 
> KReversi has problems during the game's startup and this patch was uploaded to the bug report by one of the users.
> https://bugs.kde.org/show_bug.cgi?id=341777
> 
> 
> Diffs
> -----
> 
>   qml/Board.qml e6481b4 
>   qml/Table.qml 5fe91ed 
>   startgamedialog.cpp 0202f7d 
> 
> Diff: https://git.reviewboard.kde.org/r/127989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Schwarzer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160524/22e1ca83/attachment.html>