[Kde-games-devel] Review Request 127708: KBreakout: Introduce Logging Categories

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127708/#review95326
-----------------------------------------------------------




src/kbreakout_debug.cpp (line 20)
<https://git.reviewboard.kde.org/r/127708/#comment64642>

    Maybe add the space after comma here before commit.


- Frederik Schwarzer


On April 22, 2016, 3:55 p.m., Julian Helfferich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127708/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 3:55 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kbreakout
> 
> 
> Description
> -------
> 
> I am currently trying to track down some of the more intricate bugs of kbreakout, such as bug 354517, bug 328812, and bug 328811. To get to the root of the problem, a lot of debug output is necessary.
> 
> In the process, I learned about QLoggingCategories and added them to kbreakout. Generally, I looked at how other games use QLoggingCategories and copied the approach from Laurent Montel (KSnakeDuel, Grantier) and Frederik Schwarzer (KMahjongg). However, as I am no expert in Qt, I would appreciate your feedback.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt eac51ff 
>   src/canvaswidget.cpp 1d80bfa 
>   src/gameengine.cpp 541f60c 
>   src/kbreakout_debug.h PRE-CREATION 
>   src/kbreakout_debug.cpp PRE-CREATION 
>   src/levelloader.cpp e609536 
> 
> Diff: https://git.reviewboard.kde.org/r/127708/diff/
> 
> 
> Testing
> -------
> 
> Compiled, played, confirmed that output is written to console.
> 
> 
> Thanks,
> 
> Julian Helfferich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160510/1f0490ef/attachment.html>