[Kde-games-devel] Review Request 127868: Use ${KXMLGUI_INSTALL_DIR}/lskat as destination for rc file

Albert Astals Cid aacid at kde.org
Sun May 8 22:12:39 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127868/#review95288
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On May 8, 2016, 12:06 p.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127868/
> -----------------------------------------------------------
> 
> (Updated May 8, 2016, 12:06 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: lskat
> 
> 
> Description
> -------
> 
> Fix the warning
> > KXMLGUI file found at deprecated location ("/usr/share/lskat/lskatui.rc")
> > -- please use ${KXMLGUI_INSTALL_DIR} to install this file instead.
>  
> by installing lskatui.rc at the corresponding location.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4841cc1 
> 
> Diff: https://git.reviewboard.kde.org/r/127868/diff/
> 
> 
> Testing
> -------
> 
> * Installation of lskatui.rc in new destination is successful.
> * Menu entries from rc file still there as before.
> * Warning disappears from startup.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160508/ee80a300/attachment-0001.html>


More information about the kde-games-devel mailing list