[Kde-games-devel] Review Request 127851: Drop lots of dead hyperlinks from SVGs

Martin Walch walch.martin at web.de
Fri May 6 18:25:08 UTC 2016



> On May 6, 2016, 5:49 p.m., Frederik Schwarzer wrote:
> > Do you know what once was the purpose of those links?

Sorry, no. I have no idea. They appeared first in 2007 in default.svg with commit 5b97010c49c631c1b93d9cf2fafb93d70fdc3a60 and as far as I can tell had already no corresponding anchors in the file back then.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127851/#review95244
-----------------------------------------------------------


On May 6, 2016, 5:34 p.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127851/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 5:34 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: lskat
> 
> 
> Description
> -------
> 
> There are many xlink:href attributes in linearGradient tags in the SVGs.
> Most of them refer to anchors that are not in the files, causing a lot
> of warnings "Could not resolve property : #XMLID_..."
> 
> As I do not see them serve any purpose, just remove them.
> 
> 
> Diffs
> -----
> 
>   grafix/blue.svg cdab39c 
>   grafix/egyptian.svg ed54717 
>   grafix/oxygen.svg 58a7df1 
> 
> Diff: https://git.reviewboard.kde.org/r/127851/diff/
> 
> 
> Testing
> -------
> 
> Warnings gone when playing lskat or opening the files in gwenview.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160506/f4be6d33/attachment.html>


More information about the kde-games-devel mailing list