[Kde-games-devel] Review Request 127804: Make the KApplication instantiation before calling KCrash::initialize()

Frederik Schwarzer schwarzer at kde.org
Thu May 5 11:47:46 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127804/#review95204
-----------------------------------------------------------


Ship it!




Ship It!

- Frederik Schwarzer


On May 1, 2016, 3:54 p.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127804/
> -----------------------------------------------------------
> 
> (Updated May 1, 2016, 3:54 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: lskat
> 
> 
> Description
> -------
> 
> Fix crash when calling KCrash::initialize().
> 
> This was caused by getting
> 
> "Please instantiate the QApplication object first"
> 
> as return value from QCoreApplication::applicationFilePath() when setting
> the file path in KCrash.
> 
> 
> Diffs
> -----
> 
>   src/main.cpp d70d1fe 
> 
> Diff: https://git.reviewboard.kde.org/r/127804/diff/
> 
> 
> Testing
> -------
> 
> lskat (frameworks branch) does not crash any more when starting up.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160505/0eef3096/attachment.html>


More information about the kde-games-devel mailing list