[Kde-games-devel] Review Request 127489: KBlocks: Stop playing sounds on pause

[Julian Helfferich]

> On March 27, 2016, 9:59 p.m., Albert Astals Cid wrote:
> > Honestly i don't think you need reviews for small stuff like this.
> > 
> > You can still put them up and we'll try to find time to review them, but you're the one tha tprobably knows more about kblocks code around and for things that don't have "algorighmic complexity" it's not like i can find you forgot a -1 or a delete somewhere.

I agree, the patch is pretty tiny right now. But it was only after Frederik's comment that I realized this tiny patch was all that was necessary. If you look at the original diff, you can see that my first approached was much more complicated.


- Julian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127489/#review94052
-----------------------------------------------------------


On March 25, 2016, 11:35 a.m., Julian Helfferich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127489/
> -----------------------------------------------------------
> 
> (Updated March 25, 2016, 11:35 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kblocks
> 
> 
> Description
> -------
> 
> Testing the last patch to activate sounds in KBlocks, I realized another small bug: The sounds tied to keystrokes continue playing when the game is paused.
> 
> To fix this issue, KBlocksScene now keeps track of the state of the game. To this end, the bool mGameStarted is replaced with an enum class GameState taking the values Stopped, Running or Paused. When the state changes, the signal gameStateChanged() is emitted. This signal is connected to the slot updateSoundsEnabled() which sets the sound to enabled if GameState is Running and sounds are enabled in the system settings.
> 
> In summary, I think the approach is more elaborate than what would be necessary, but more preferable to change the sound separately in startGame(), stopGame() and pauseGame().
> 
> 
> Diffs
> -----
> 
>   KBlocksWin.cpp 522bfdd 
> 
> Diff: https://git.reviewboard.kde.org/r/127489/diff/
> 
> 
> Testing
> -------
> 
> Played the game.
> 
> * Enabled and disabled the sound while game is running.
> * Enabled and disabled the sound when game is paused.
> 
> 
> Thanks,
> 
> Julian Helfferich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160328/94d48a67/attachment.html>