[Kde-games-devel] Review Request 127489: KBlocks: Stop playing sounds on pause

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127489/
-----------------------------------------------------------

(Updated March 25, 2016, 11:35 a.m.)


Review request for KDE Games.


Changes
-------

There is a much easier way to fix this bug.


Repository: kblocks


Description
-------

Testing the last patch to activate sounds in KBlocks, I realized another small bug: The sounds tied to keystrokes continue playing when the game is paused.

To fix this issue, KBlocksScene now keeps track of the state of the game. To this end, the bool mGameStarted is replaced with an enum class GameState taking the values Stopped, Running or Paused. When the state changes, the signal gameStateChanged() is emitted. This signal is connected to the slot updateSoundsEnabled() which sets the sound to enabled if GameState is Running and sounds are enabled in the system settings.

In summary, I think the approach is more elaborate than what would be necessary, but more preferable to change the sound separately in startGame(), stopGame() and pauseGame().


Diffs (updated)
-----

  KBlocksWin.cpp 522bfdd 

Diff: https://git.reviewboard.kde.org/r/127489/diff/


Testing
-------

Played the game.

* Enabled and disabled the sound while game is running.
* Enabled and disabled the sound when game is paused.


Thanks,

Julian Helfferich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160325/4d510913/attachment.html>