[Kde-games-devel] Review Request 127433: [kblocks] Unbreak startup, add dependencies

[Julian Helfferich]

> On March 21, 2016, 1:33 p.m., Julian Helfferich wrote:
> > I have looked a little bit into KDBusService and it seems to be the reason for the break. If I understand it correctly, the program starts, but since it does not register with the DBus, KDEInit thinks the startup failed.
> > 
> > But shouldn't app.setApplicationName("KBlocks") and app.setOrganizationDomain("kde.org") be called before registering the DBus? As far as I know, KBlocks does not do this yet.
> 
> Albert Astals Cid wrote:
>     that's most probably the default, have you tried the patch?
> 
> Andreas Sturmlechner wrote:
>     It works for me at least without setting these bits, didn't copy these changes from kpat after noticing other apps also did without.

I just found out, that the DBus service name is specified in the .desktop file. So there is no need to set it in the application.


- Julian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127433/#review93817
-----------------------------------------------------------


On March 21, 2016, 8:08 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127433/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 8:08 p.m.)
> 
> 
> Review request for KDE Games, Julian Helfferich and Frederik Schwarzer.
> 
> 
> Repository: kblocks
> 
> 
> Description
> -------
> 
> Fixes https://bugs.kde.org/show_bug.cgi?id=357408 and adds dependencies to not rely on kdelibs4support to pull them in.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 761749306a15866957ce94a726fa8654bb1b5d53 
>   main.cpp 6ae9d5677be4f69ef0cc76a057a41407e22b942d 
> 
> Diff: https://git.reviewboard.kde.org/r/127433/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs fine.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160322/cd987707/attachment.html>