[Kde-games-devel] Review Request 127433: [kblocks] Unbreak startup, add dependencies

[Frederik Schwarzer]

> On March 20, 2016, 12:37 p.m., Frederik Schwarzer wrote:
> > CMakeLists.txt, line 24
> > <https://git.reviewboard.kde.org/r/127433/diff/1/?file=453636#file453636line24>
> >
> >     @Julian: since you ported KBlocks away from Phonon, please remove the Phonon-reated stuff from he CMake file as well.
> >     
> >     The rest of the review I leave to Julian, since he is the maintainer. :)
> 
> Andreas Sturmlechner wrote:
>     I was unsuspicious of Phonon because it still ended up being linked, but I looked into it to try and remove it. No matter what though, there is no sound in kblocks for me.

The note was meant for Julius, since it has nothing to do with your change. :)

Since the sounds had not been activated before, Julius first ported to KgSound and now activated the sounds in:
https://git.reviewboard.kde.org/r/127370/


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127433/#review93784
-----------------------------------------------------------


On March 20, 2016, 12:32 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127433/
> -----------------------------------------------------------
> 
> (Updated March 20, 2016, 12:32 p.m.)
> 
> 
> Review request for KDE Games, Julian Helfferich and Frederik Schwarzer.
> 
> 
> Repository: kblocks
> 
> 
> Description
> -------
> 
> Fixes https://bugs.kde.org/show_bug.cgi?id=357408 and adds dependencies to not rely on kdelibs4support to pull them in.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 761749306a15866957ce94a726fa8654bb1b5d53 
>   main.cpp 6ae9d5677be4f69ef0cc76a057a41407e22b942d 
> 
> Diff: https://git.reviewboard.kde.org/r/127433/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs fine.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160320/255d58e5/attachment.html>