[Kde-games-devel] Review Request 127399: [kjumpingcube] Remove unused deps, unbreak startup

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127399/#review93779
-----------------------------------------------------------


Fix it, then Ship it!





main.cpp (lines 80 - 84)
<https://git.reviewboard.kde.org/r/127399/#comment63919>

    No need to upload another diff for this, but when you commit, please make this a separate commit. (git add -p)
    In case someone wants to revert your dbus change for some reason, this whitespace cleanup can be kept. You know, just my daily nitpicking bit. :)


- Frederik Schwarzer


On March 20, 2016, 10:54 a.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127399/
> -----------------------------------------------------------
> 
> (Updated March 20, 2016, 10:54 a.m.)
> 
> 
> Review request for KDE Games, Ian Wadham and Frederik Schwarzer.
> 
> 
> Bugs: 357409
>     http://bugs.kde.org/show_bug.cgi?id=357409
> 
> 
> Repository: kjumpingcube
> 
> 
> Description
> -------
> 
> Removed unused deps. Added a second commit that unbreaks startup.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a53ac48b795a31855fa2518135d245563ed6c55b 
>   main.cpp 46a8759c8cecf9b02c7ea91ea7d093e56ea715b0 
> 
> Diff: https://git.reviewboard.kde.org/r/127399/diff/
> 
> 
> Testing
> -------
> 
> Builds fine without these deps.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160320/3bca9eee/attachment-0001.html>